I think the joint placements are looking pretty good, I sketched up what the controllers could look like. For the shoulder it would be great if I could click on the control and translate the shoulders xyz, rotation may be necessary also for poses where the character is reaching upwards or when the elbows are in, I find that a lot of rigs have problems with the shoulders looking ugly in these kind of poses.